feat: check destination address for SC wallets #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dewanshparashar
changed the title
…e into fs-1035/custom-dest-address-check
fionnachan
reviewed
Dec 13, 2024
packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx
Outdated
Show resolved
Hide resolved
...-token-bridge-ui/src/components/TransferPanel/CustomDestinationAddressConfirmationDialog.tsx
Outdated
Show resolved
Hide resolved
fionnachan
previously approved these changes
Dec 16, 2024
chrstph-dvx
requested changes
Dec 17, 2024
| <div className="mb-4"> | ||
| <p className="pb-2"> | ||
| You are attempting to deposit funds to the same address{' '} | ||
| {shortenAddress(destinationAddress)} on {networkName}. |
There was a problem hiding this comment.
Would be nice to have a link to the address on the explorer.
| isDepositMode && | ||
| areSenderAndCustomDestinationAddressesEqual | ||
| ) { | ||
| await confirmCustomDestinationAddressForSCWallets() |
There was a problem hiding this comment.
Same on L626. Currently if user click on cancel or close, we proceed as if user click on confirm. We should check for the returned value here
chrstph-dvx
approved these changes
Dec 17, 2024
fionnachan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-1035